Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Sign Windows binary inplace #183

Merged
merged 8 commits into from
Apr 6, 2023
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Apr 3, 2023

We should be able to sign inplace now: SSLcom/actions-codesigner#1

This PR should do it, but I expect some timeout failures we'll need to debug before 1.4. No idea why it took so long on a couple of platforms when I was testing in an isolated branch in this repo, we'll see if it happens again.

@larsoner
Copy link
Member Author

larsoner commented Apr 6, 2023

I vaguely recall somewhere in the conda or napari docs saying that pinning versions can speed up resolution. Given that resolution took ~30 minutes on macOS and we can get our list of outdated dependencies using python tests/test_outdated.py in ~1 min, I'm seeing what happens if I pin everything. Hopefully it runs much faster...

@larsoner
Copy link
Member Author

larsoner commented Apr 6, 2023

By pinning:

  • macOS: 30 min down to 9 min
  • macOS ARM: 20 min down to 6 min
  • Ubuntu: 24 min down to 5 min
  • Windows: 15 min down to 11 min

@larsoner larsoner enabled auto-merge (squash) April 6, 2023 01:44
@hoechenberger
Copy link
Member

By pinning:

  • macOS: 30 min down to 9 min
  • macOS ARM: 20 min down to 6 min
  • Ubuntu: 24 min down to 5 min
  • Windows: 15 min down to 11 min

Amazing improvements!

I'm just worried we might run into dependency resolution errors someday if we start pinning too many things. But as long as it works, let's keep it!

Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
@larsoner
Copy link
Member Author

larsoner commented Apr 6, 2023

I did in 545caad actually but it was fairly easy to resolve. Agreed we should undo it later if needed. FWIW it also gives us some indication of when packages are not all up to date across all architectures due to conflicts, which is otherwise hidden/implicit. In this case currently it's only fsleyes on windows and vtk on Mac non-ARM.

@larsoner larsoner merged commit dee6706 into mne-tools:main Apr 6, 2023
13 checks passed
@larsoner larsoner deleted the testsign branch April 6, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants