-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use matplotlib-based raw browser in docs #10481
Comments
Looks like you missed #9960 and #10359 where we worked out using the Qt backend in the doc build, since this sounds like an argument to undo most of that. Given that people at the time at least were more or less "pro" this change IIRC, I'd assume they're -1 on reverting it now.
In principle we could add zen-mode-style capture. However, even back when we used matplotlib we included the UI elements like scrollbars, e.g. here. Personally I don't mind having them in there because it's a bit closer to the user experience and doesn't take up too much space (unlike in We could consider individual elements:
I guess we could hide the toolbar and overview-mode-selector. The downside is that it creates a mismatch with what the user will see, but I guess it's an understandable one. I'm +/-0 on this. |
Seems like I did! I'm OK with not hiding everything, but at least the toolbar and the overview bar do not add any important information. If they do in a particular example, we could explicitly enable them, but by default I'd hide them. Usually, we want to show the continuous signals in the tutorials (even in the example you mentioned), and we don't need the scrollbars or anything else. So if the backend cannot be reverted, I'd vote for a zen-mode-like display (no overview bar, no toolbar, and even no scrollbars, although I'd be OK with leaving those in). |
So things to improve, assuming we stick with Qt (which I think we should, since it's our default):
Currently, the overview bar is always shown. One advantage to it for users -- in addition to being a source of information about annot/events/zscore -- is that you can interact with it to get to a location in the channel-time plane. Considering this, I think my +1 goes to (for simplicity) not bothering to add We can go either 1) opt-in where the overview bark isn't scraped unless a |
I'd love an I would leave the overview bar on for users, because it adds helpful information. However, I think the overview bar should be opt-in in the docs. Usually, we want to show the raw signals and not so much the exact interactive interface. If this is the goal, we can enable the bar explicitly. I'd actually prefer the argument over the scraper, because I think it might be useful for people to open the raw browser with their preferred overview bar mode. This could also be a setting we could store in the config. |
That would end up being pretty easy implementation-wise, too, because we can just |
I think that showing raw plots in our docs should not include toolbar icons, scrollbars, and other interactive (irrelevant) items, as is the case since 1.0 (e.g. the screenshot in https://mne.tools/dev/auto_examples/io/read_xdf.html).
I would switch to the matplotlib backend in our docs to get rid of UI elements, unless it is also possible to do this with the qt backend (zen mode maybe?).
The text was updated successfully, but these errors were encountered: