New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: draft of mne report command #1261
Conversation
|
||
from matplotlib.backends.backend_agg import FigureCanvasAgg as FigureCanvas | ||
from matplotlib.figure import Figure | ||
import pylab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use pyplot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and plt shortcut
can you update the PR header with tick boxes with the todos that comes to mind? |
@agramfort @dengemann : what do we do about viewing raw data? sliders in mne_browse_raw style? writing binary images may be very cumbersome -- should we hack something in d3 ? something like this: https://github.com/mbostock/d3/wiki/Zoom-Behavior + tempita. Any other suggestions? |
for now for the Raw just print the REPR and the info repr a javascript raw browser is beyond the scope for a minimal working PR |
+1 for Table of contents linking to different parts of html the bootstrap/JS theme should allow to select which type of fif file to display. See jquery toggle also bad fif files should appear in red for example if the fif fname is not standard (evoked should end with -ave.fif, cov with -cov.fif, raw with raw.fif or sss.fiff etc....) |
ok, we now have a table of contents + bad file names in red. Does |
if not please open a PR to fix this. Or maybe wait for the io module PR to be merged to avoid a merging/rebasing mess... |
how about a black banner on top as in : http://getbootstrap.com/examples/jumbotron/ that says "MNE Report for /path/to/folfer" in the footer a link saying "Powered by MNE" with a link to martinos.org/mne just coming up with ideas to make it nice and look pro :) |
you should also think of how to render the -trans.fif files. it would be great to display head in helmet to check coregistration quality. You'll need a bit of work to make it work. I recommend to do it in another PR with a mne.viz.plot_trans function. |
+1, that would be awesome. I can also work on this if @mainakjas your time is better spent elsewhere. If you do want to work on it, all the transformations, surfaces, and their relationships that you need you can dig out of the field lines example. |
Thanks @agramfort @Eric89GXL. I am just updating the mne-report with the navbar + footer as we speak + some other minor modifications. Nice idea about checking coregistration quality but I'll check in a day or two to estimate how much effort is required there. |
Another idea is to open the report in a browser when generated. Look at how "ipython notebook" does it |
ok, sounds good. I have now added the navbar + footer. The button toggling has been included in the navbar now such that all buttons (eve, cov etc) are in the "on" state initially but the user can turn them off as required. |
would you be ok with a dependency on |
Fwiw, this is part of import webbrowser
webbrowser.open_new_tab("http://localhost:8888") |
beautiful ! thanks for the tip |
@agramfort : just to be sure, what are the coordinates X, Y, Z? Do we need those since the slider values are displayed below the image anyway? |
also, what about the color map selector for *.mgz files? I suppose that'll blow the size of the html file exponentially. Maybe we should just expose the option of selecting color map from python and not html? |
Drop cmap support and use only gray |
Probably not |
any progress here? you should address the plot_trans function but in a different PR. another PR you could write is one that throws warning with saving and reading fif files with non-standard extensions. To force gently the use of our conventions... |
I'm back at this now. Will make new PR soon :) |
@mainakjas how is it going here? Let me know as soon as you think you could need a hang out. |
I'll look at plot_trans function next unless something else should get higher priority. |
|
- Use plot_cov to get covariance plots - Fix tests - Make _render_eve work without sfreq
FIX1: Use realpath instead of abspath FIX2: Do not try to render -trans.fif if subjects_dir and subject not provided FIX3: Pass full path for saving report. Default is self.data_path
you have my +1 for merge ! any other last review? if you're bored today you could add a -j param to build the html in parallel :) |
merged by rebase ! awesome work @mainakjas ! |
@mainakjas hooray!!! |
indeed @dengemann ! On Sat, Jul 19, 2014 at 4:41 PM, Denis A. Engemann <notifications@github.com
|
Closes #1056
Try
and it should generate
report.html
inMNE-sample-data/
Sample output here: https://dl.dropboxusercontent.com/u/3915954/report.html
TODOS
mne.viz.plot_trans()
)