Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Preprocessing module instead of artifacts and preprocessing #209

Closed
dengemann opened this issue Dec 3, 2012 · 6 comments
Closed

ENH: Preprocessing module instead of artifacts and preprocessing #209

dengemann opened this issue Dec 3, 2012 · 6 comments

Comments

@dengemann
Copy link
Member

Hi all,

I wondered why we actually have two modules for very interrelated operations. Also ICA for example is more then just about artefacts. For the sake of consistency and simplicity I'd suggest to move artefacts to preprocessing. What do you think?

Denis

@agramfort
Copy link
Member

+1 I agree. We'll need to deprecate stuff properly though

@dengemann
Copy link
Member Author

Mhm, true. Just wondering what would be the simplest way to do this. Add depracation decorators / warnings to the functions from release 3.0 and copy everything to preprocessing. Or instead of copying (automagically) redirect to the new location after warning. Any preferences, thoughts?

@agramfort
Copy link
Member

decorate with deprecated each moved function.

@dengemann
Copy link
Member Author

Sure, so just to double check: we will keep mne/artifacts but everything
there will be deprecated, right?

On Mon, Dec 3, 2012 at 4:46 PM, Alexandre Gramfort <notifications@github.com

wrote:

decorate with deprecated each moved function.


Reply to this email directly or view it on GitHubhttps://github.com//issues/209#issuecomment-10958097.

@agramfort
Copy link
Member

Sure, so just to double check: we will keep mne/artifacts but everything
there will be deprecated, right?

yes

@dengemann
Copy link
Member Author

Closing this one, to be continued in the subsequent PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants