Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to EDF using pyEDFLib #5755

Closed
skjerns opened this issue Nov 29, 2018 · 5 comments
Closed

Export to EDF using pyEDFLib #5755

skjerns opened this issue Nov 29, 2018 · 5 comments

Comments

@skjerns
Copy link
Contributor

skjerns commented Nov 29, 2018

Problem
Right now it is only possible to export data using FIF, which is not a very useful and widely used file format. I do remember seing an issue about integration of some EDF library, but at this point I can't find it again.

Suggestion
I'd like to make a first, basic addition to integrate pyEDFlib for writing EDF+ files to disk. I'm using this library since some time and have good experience with it.

However I have a few questions regarding the approach:

  • Would it be okay to use an external library for saving EDF instead of re-inventing the wheel?
  • Where should I insert the code? I thought to extend BaseRaw with a function save_edf(), however it would also be possible to alter .save() to accept different file types
  • in the basic version, this would save channels (and annotations?) only as raw as they are. I have no experience with all the Evoked, Epoched, etc. and if we could save them appropriately via EDF.

Alternatives
Write a native EDF-writer, which at this point I do not have the time for.

edit:
I've created a gist as requested here: https://gist.github.com/skjerns/bc660ef59dca0dbd53f00ed38c42f6be

@agramfort
Copy link
Member

agramfort commented Nov 29, 2018 via email

@massich
Copy link
Contributor

massich commented Nov 30, 2018

The entire EDF business needs some care. (see #5741)

@skjerns
Copy link
Contributor Author

skjerns commented Dec 6, 2018

@agramfort I've created a gist, however, I doubt where exactly I should place it.. As an example? inside the IO docs? Inside an existing doc?

@agramfort
Copy link
Member

yes I would add a link to the gist at the end of the edf section here https://github.com/mne-tools/mne-python/blob/master/doc/manual/io.rst#european-data-format-edf

@cbrnr
Copy link
Contributor

cbrnr commented Dec 12, 2018

Closing since this was fixed in #5777, but if a pure-Python solution emerges in the future, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants