Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add ctrl+key or alt+key as another way to move in large steps. #7805

Open
seankmartin opened this issue May 21, 2020 · 4 comments
Open

Comments

@seankmartin
Copy link

Problem

There is a bug that can occur in the matplotlib tkinter backend that can prevent shift+key combo events from being correctly passed. A shift+key combo is used in mne interactive plots to move in large steps, and the tkinter backend bug can break this feature.

Solution

A good enhancement would be to add the additional keybind ctrl+key or alt+key which performs the same functionality as shift+key in case a user has this bug.

Alternative

Alternatively, using the pyqt5 backend for matplotlib also fixes this bug, but this would require pyqt5 to be installed.

Additional context

This issue was discussed on gitter before posting here.

@cbrnr
Copy link
Contributor

cbrnr commented May 21, 2020

Good idea!

@larsoner
Copy link
Member

+0.5 for ctrl+key over alt+key

@rob-luke
Copy link
Member

This is slightly off topic (so maybe I should open another issue?), but if someone is reorganising that section of the code it would be really handy to be able to use the modifier key to also make large changes in the time shown per view. e.g. if currently pressing end increases the time shown from 10 to 11 seconds, presssing ctrl+end would double the time view from 10 to 20 seconds.

@cbrnr
Copy link
Contributor

cbrnr commented May 22, 2020

Also +0.5 for ctrl+key. I think this change and @rob-luke's suggestions can be tackled with one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants