Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Try to improve Report generation performance #10105

Closed
wants to merge 1 commit into from

Conversation

hoechenberger
Copy link
Member

Currently this is really just here for @agramfort and won't be of interest to anyone else

@bloyl
Copy link
Contributor

bloyl commented Dec 7, 2021

hi @hoechenberger,

Firstly, I really like the new reporting functionality. So thank you for that effort.

I wonder if there is any opportunity to also support the following for add_raw

  1. Adjust the 1 second interval to longer (or shorter I guess ) time intervals.
  2. Adjust the scaling on the raw butterfly plots.
    For my base CTF data it is often off the scale. image

Maybe collapsed into a butterfly_kwargs argument or something similar?

Best,
Luke

@hoechenberger
Copy link
Member Author

Hello @bloyl, Report.add_raw() now has a scalings parameter: #10109

Currently we don't support a way to specify custom durations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants