MRG: Omit annotations in raw butterfly plots in Report #10114
Conversation
This drastically reduced butterfly plotting for me locally with a test dataset (8 runs of MEG), by more than 35% (145 seconds instead of 227)
mne/report/report.py
Outdated
| self, *, raw: BaseRaw, image_format, tags | ||
| ): | ||
| orig_annotations = raw.annotations.copy() | ||
| raw.set_annotations(None) |
There was a problem hiding this comment.
Since raw can be passed directly rather than via filename, this should really be wrapped in a try/finally (or equivalently, a @contextmanager) that ensures that, no matter what, raw.set_annotations(orig_annotations gets called
There was a problem hiding this comment.
(like if there is an error with plotting, or the user presses ctrl-C during plotting, etc.)
There was a problem hiding this comment.
I think the cleanest approach would be to add a new kwarg to plot_raw, but the signature is already so massive....
There was a problem hiding this comment.
It would be tricky there because of interactive plotting mode. I would assume YAGNI on that
There was a problem hiding this comment.
I've decided to go with try/except for now. LMK if you'd prefer a context manager instead (I felt it was a bit overkill but I'm open to revise this judgment :))
hoechenberger
changed the title
|
thx @hoechenberger merge when green @hoechenberger 🙏 |
This drastically reduced butterfly plotting for me locally with a test dataset (8 runs of MEG), by more than 35%
(145 seconds instead of 227)
Should only go in after #10109 has been merged.
x-ref #10107
Todo:
cc @agramfort