Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MNE subpackages to sys_info() #10261

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Conversation

rob-luke
Copy link
Member

@rob-luke rob-luke commented Jan 27, 2022

Reference issue

This is an issue as PR.

What does this implement/fix?

My immediate go-to when I have issues or help someone else is mne.sys_info(). Often in my case however, issues are caused by incompatibilities between various MNE sub packages (which I define as python packages hosted within the mne-tools organisation that aren't MNE-Python). I see that the sub package mne_qt_browser has been added to sys_info (but I guess this is because there are plans to merge it to MNE-Python in the future). And mne_bids was already included.

Can we add the other sub packages to the sys info output? E.g. NIRS, Connectivity, Features

Additional information

I also moved mne_bids from developer to user dependencies, as I think its commonly used by non developers too.

I wasn't sure if mne-bids-pipeline fitted in to this scope and should be added too? Or if its more a tool in itself.

@larsoner
Copy link
Member

I think no to MNE-BIDS-Pipeline because it's not a proper package (?) but let's see what @hoechenberger and @agramfort say. +1 for merge from my end

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes mne-bids-pipeline is not a package (maybe at this point)

@hoechenberger
Copy link
Member

The BIDS Pipeline so far isn't a proper package and hence shouldn't be listed here
(but see my idea for a pipeline runner package)

@larsoner larsoner marked this pull request as ready for review January 28, 2022 15:20
@larsoner larsoner merged commit addab68 into mne-tools:main Jan 28, 2022
@larsoner
Copy link
Member

Okay I merged as-is even though it was draft since it seemed complete enough to me, but feel free to open a PR for any follow-up changes if you had some in mind @rob-luke

@rob-luke
Copy link
Member Author

Thanks

@sappelhoff
Copy link
Member

We get the following error on mne-bids main CI when testing with MNE-Python main, I suspect this PR had something to do with it: https://github.com/mne-tools/mne-bids/runs/4997582345?check_suite_focus=true

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.2/x64/bin/mne", line 33, in <module>
    sys.exit(load_entry_point('mne', 'console_scripts', 'mne')())
  File "/opt/hostedtoolcache/Python/3.10.2/x64/bin/mne", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/importlib/metadata/__init__.py", line 162, in load
    module = import_module(match.group('module'))
  File "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/runner/work/mne-bids/mne-bids/mne-python/mne/__init__.py", line 22, in <module>
    from .utils import (set_log_level, set_log_file, verbose, set_config,
  File "/home/runner/work/mne-bids/mne-bids/mne-python/mne/utils/__init__.py", line 9, in <module>
    from .check import (check_fname, check_version, check_random_state,
  File "/home/runner/work/mne-bids/mne-bids/mne-python/mne/utils/check.py", line 21, in <module>
    from ._logging import warn, logger, verbose
  File "/home/runner/work/mne-bids/mne-bids/mne-python/mne/utils/_logging.py", line 8, in <module>
    from decorator import FunctionMaker
ModuleNotFoundError: No module named 'decorator'

@agramfort
Copy link
Member

agramfort commented Jan 30, 2022 via email

sappelhoff added a commit to mne-tools/mne-bids that referenced this pull request Jan 30, 2022
@sappelhoff
Copy link
Member

Just tried, it's not the caching.

@agramfort
Copy link
Member

agramfort commented Jan 30, 2022 via email

@sappelhoff
Copy link
Member

ah, wait --- I updated the circleci caches, ... need to do this for GH actions. Sorry for the noise.

@sappelhoff
Copy link
Member

the issue is that we do

        git clone --depth 1 https://github.com/mne-tools/mne-python.git -b main
        pip install --no-deps -e ./mne-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants