ENH Brainvision: option to add reference channel #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t3on could you have a look if you have some time? |
| @@ -453,13 +473,13 @@ def _get_eeg_info(vhdr_fname, elp_fname=None, elp_names=None): | |||
|
|
|||
| # load channel labels | |||
| ch_names = ['UNKNOWN'] * n_chan | |||
| cals = np.ones(n_chan) * np.nan | |||
| cals = [np.nan] * n_chan | |||
There was a problem hiding this comment.
made an array again
|
Changes Unknown when pulling a54bf35 on christianmbrodbeck:bv-ref into * on mne-tools:master*. |
|
What exactly does this @coveralls message mean? When I run coverage brainvision.py has 89% coverage. |
|
Same idea as Travis, it runs a limits set of tests so it provides a guideline / check (add opposed to substitute for running tests locally). |
|
hey. i just gave it a review and it looks good to me. do we know why there is a discrepancy between the two coverages? |
agramfort
added a commit
that referenced
this pull request
Jan 12, 2014
ENH Brainvision: option to add reference channel
|
thanks @t3on there is a discrepancy between travis and your system as travis does not test using the sample data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Brainvision EEG file does not contain data for the reference channel. However, for re-referencing one would also want to have the reference channel in the data. This patch adds the reference channel as a flat channel.