[MAINT] Fix colorbar #10443
Merged
[MAINT] Fix colorbar #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see a point in backporting, 1.0 release is imminent and that's when we'll stop supporting 0.24 |
|
Taking the colorbar off of gridspec really messes with the plotting so I thought it would be nice to have in 0.24 but I think you're right, let's not |
|
Thanks @alexrockhill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, one last fix with the changes. Before,
fig.tight_layoutdidn't work and so the title overlapped the text. When I letaxbe passed directly, it allowedfig.tight_layoutbut the colorbar didn't work with it. This allows the previous functionality of specifying the position of the colorbar, but makes the default not have overlapping text withfig.tight_layout.