MAINT: Dont use ABC #10508
Closed
MAINT: Dont use ABC #10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I think we'll want to wait for mne-tools/mne-qt-browser#104 and merge them simultaneously, because removing the ABC actually causes a problem with the latest released mne-qt-browser. |
|
I think I found a different solution in mne-tools/mne-qt-browser#104, namely to change the MRO. Since our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on mne-tools/mne-qt-browser#104 on PySide6 + macOS I hit a bug where PySide6 does not play nicely with ABC:
https://askpythonquestions.com/2022/01/07/pyside6-shiboken-and-abcmeta-bug
I don't think we need the BrowserBase to be an ABC subclass, even if it's nice to have it that way. Given that it breaks PySide6 (which seems to be the preferred framework going forward), it seems worth it to remove it here.