MRG: Updates for qtpy in mne-qt-browser #10509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 9, 2022
larsoner
commented
Apr 9, 2022
Comment on lines
+224
to
+225
| if sys.platform == 'darwin': # unknown transformation bug | ||
| monkeypatch.setenv('MNE_BROWSE_RAW_SIZE', '20,20') |
There was a problem hiding this comment.
This was necessary to get PySide6 macOS to pass for mne-qt-browser in mne-tools/mne-qt-browser#104, but not locally. I don't get it, but this should help stabilize things a bit hopefully 🤷
larsoner
changed the title
|
#10500 should go in before this one |
larsoner
changed the title
|
I'll merge this and move on to mne-tools/mne-qt-browser#104 ! |
larsoner
added a commit
to wmvanvliet/mne-python
that referenced
this pull request
Apr 19, 2022
* upstream/main: (40 commits) FIX: Flake (mne-tools#10540) FIX: Correct link (mne-tools#10536) DOC: Update installers (mne-tools#10535) ENH: Add dark mode to website (mne-tools#10523) WIP: Copy BEM surfaces by default (don't symlink) (mne-tools#10531) Avoid lowpass=0 in brainvision data (mne-tools#10517) DOC: Update installers [skip azp] [skip actions] (mne-tools#10528) FIX: Fix for old build (mne-tools#10527) Fix line noise at wrong frequencies (mne-tools#10525) FIX : read fids in eeglab (mne-tools#10521) MAINT: Prefer PySide6 in testing (mne-tools#10513) ENH: Add overview_mode support (mne-tools#10501) MRG: Updates for qtpy in mne-qt-browser (mne-tools#10509) BUG: Fix bug with themes on macOS (mne-tools#10500) MAINT: Bump installer links (mne-tools#10511) Add metadata to combine_channels (mne-tools#10504) MAINT: Standardize tests (mne-tools#10502) CI: Test circle (mne-tools#10506) ENH: Use HiDPI splash screen on HiDPI screens (mne-tools#10503) WIP,MNT: Add support for QtPy (mne-tools#10430) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For qtpy support in mne-qt-browser, we need to update our testing infrastructure in MNE-Python, since our checks currently look to see if PyQt5 is installed.
I also added
pyqtgraphtomne sys_info.