Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/FIX/MAINT: add back support for MacOSX backend in mpl #1052

Merged
merged 6 commits into from
Jan 10, 2014

Conversation

dengemann
Copy link
Member

cc @agramfort @Eric89GXL

fig = plt.gcf()
fig.tight_layout(pad=pad, h_pad=h_pad, w_pad=w_pad)

try: # see https://github.com/matplotlib/matplotlib/issues/2654
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI ping @Eric89GXL @agramfort

@agramfort
Copy link
Member

let us know when we shall review

@dengemann
Copy link
Member Author

now.

@@ -1354,15 +1357,21 @@ def _draw_proj_checkbox(event, params, draw_current_state=True):
import matplotlib as mpl
projs = params['projs']
# turn on options dialog
fig_proj = figure_nobar()
global fig_proj
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops debug...

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0576cbd on dengemann:mpl_maint into 1bc4d40 on mne-tools:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0576cbd on dengemann:mpl_maint into 1bc4d40 on mne-tools:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c2a4203 on dengemann:mpl_maint into 1bc4d40 on mne-tools:master.

@dengemann
Copy link
Member Author

@Eric89GXL @christianmbrodbeck transatlantic Mac users --- would you like to pull and run a few examples? The most critical ones are from raw to epochs to ... and delayed ssp where the axis plot and the proj toggle box can get terribly wrong. Run this once with qt, once with osx backend.
Would be great thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 33733e2 on dengemann:mpl_maint into 1bc4d40 on mne-tools:master.

dengemann pushed a commit that referenced this pull request Jan 10, 2014
ENH/FIX/MAINT: add back support for MacOSX backend in mpl
@dengemann dengemann merged commit 509ab77 into mne-tools:master Jan 10, 2014
@dengemann
Copy link
Member Author

@agramfort @Eric89GXL blame me if you encounter surprises.

@larsoner
Copy link
Member

@dengemann sorry for the slow response, been a bit busy with work to bust out the ol' laptop. I'm not 100% sure I have everything working on it currently.

@dengemann
Copy link
Member Author

@Eric89GXL don't you worry. I'm sure you will ping me if something looks weird ;-) but I'm actually confident that these changes are benign. Tested things against osx and qt with real-world tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants