-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH/FIX/MAINT: add back support for MacOSX backend in mpl #1052
Conversation
fig = plt.gcf() | ||
fig.tight_layout(pad=pad, h_pad=h_pad, w_pad=w_pad) | ||
|
||
try: # see https://github.com/matplotlib/matplotlib/issues/2654 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI ping @Eric89GXL @agramfort
let us know when we shall review |
now. |
@@ -1354,15 +1357,21 @@ def _draw_proj_checkbox(event, params, draw_current_state=True): | |||
import matplotlib as mpl | |||
projs = params['projs'] | |||
# turn on options dialog | |||
fig_proj = figure_nobar() | |||
global fig_proj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops debug...
@Eric89GXL @christianmbrodbeck transatlantic Mac users --- would you like to pull and run a few examples? The most critical ones are from raw to epochs to ... and delayed ssp where the axis plot and the proj toggle box can get terribly wrong. Run this once with qt, once with osx backend. |
ENH/FIX/MAINT: add back support for MacOSX backend in mpl
@agramfort @Eric89GXL blame me if you encounter surprises. |
@dengemann sorry for the slow response, been a bit busy with work to bust out the ol' laptop. I'm not 100% sure I have everything working on it currently. |
@Eric89GXL don't you worry. I'm sure you will ping me if something looks weird ;-) but I'm actually confident that these changes are benign. Tested things against osx and qt with real-world tasks. |
cc @agramfort @Eric89GXL