-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improved Circle Plot #1090
Conversation
fmax=fmax, faverage=True, mt_adaptive=True, n_jobs=2) | ||
|
||
# con is a 3D array, get the connectivity for the first (and only) freq. band | ||
con = con[:, :, 0] | ||
# for each method | ||
con = {m: c[:, :, 0] for m, c in zip(con_methods, con)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not python 2.6 compatible :-( --- no dict comprehension literal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. maybe it's time to drop Py2.6 support. Why do we need it, i.e., is anyone (who is using Python science) still using Py 2.6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. maybe it's time to drop Py2.6 support. Why do we need it, i.e., is anyone (who is using Python science) still using Py 2.6?
some stable linux distro still have 2.6 and I've been working hard to have
debian/ubuntu packaging to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.. silly Debian. Here goes the beautiful dict comprehension :(
@dengemann @agramfort addressed comments. |
Please merge if you are happy.. |
in @mluessi we trust ! :) |
Some circle plot improvements to make it work in subplots, also exposes additional options for font sizes etc.
There may be a bug in matplotlib; it doesn't take into account the sizes of the node labels when arranging the subplots, so they end up overlapping. As a workaround I added the
padding
parameter which allows the user to manually add space around the circle. The second plot from the example looks like this:I wanted to keep the first figure as it has 1:1 aspect ratio, which looks nice in the thumbnail page.