Standard Montage layout: easycap-M43 #11739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Official layout for easycap-M43:
Test results:
|
|
looks like a good addition, thanks! The CI style check is failing, please install our pre-commit hook so that this won't happen again (you may need to install pre-commit, black, and/or ruff first). Will also need a changelog entry under "Enhancements" |
sappelhoff
reviewed
Jun 18, 2023
There was a problem hiding this comment.
Thanks! Approved conditionally on fulfillment of Dan's points above: #11739 (comment)
|
Closing this one since I have opened a new PR #11742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #11737
What does this implement/fix?
Creates a standard montage layout for easycap-M43 system.