-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH, FIX: Make eyelink occular annotations "channel aware", and call blink annotations "BAD" #11746
Merged
larsoner
merged 10 commits into
mne-tools:main
from
scott-huberty:read_raw_eyelink_annots
Jun 23, 2023
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b7c14ff
ENH: make occular annotations channel aware
scott-huberty 1c52f09
STY: Move read_raw_eyelinkhelper funcs to _utils module
scott-huberty ce50be1
FIX: change "blink" annotations to "BAD_blink"
scott-huberty 380f1e1
DOC: Update changelog and tutorials
scott-huberty 7ffcc83
Apply suggestions from code review [ci skip]
scott-huberty b70c3f6
FIX: added Eric's suggestion
scott-huberty 85a5ce4
Merge branch 'main' of https://github.com/mne-tools/mne-python into r…
scott-huberty e1c0797
FIX: Remove eye name from ocular annot description
scott-huberty ad04662
FIX: Code coverage pass
scott-huberty c0beff2
FIX: for ubuntu latest..
scott-huberty File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead let's use convenience functions as much as possible, like
Then you can just do your try/except without any type business
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, to clarify, that would be:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently you raise an error for anything other than
str
, then try to convert to float and return True/False based on floatiness. So I guess it should be: