Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Use wmparc in add_volume_labels #12576

Merged
merged 14 commits into from Apr 27, 2024
Merged

Conversation

alexrockhill
Copy link
Contributor

The aparc+aseg is no longer automatically included in the latest freesurfer recon-all.

@alexrockhill alexrockhill changed the title ENH: Use wmparc in add_volume_labels BUG: Use wmparc in add_volume_labels Apr 25, 2024
mne/viz/_brain/_brain.py Outdated Show resolved Hide resolved
Copy link
Contributor

@wmvanvliet wmvanvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

mne/utils/docs.py Outdated Show resolved Hide resolved
@alexrockhill
Copy link
Contributor Author

Thanks for the review @wmvanvliet , looks good to go now

mne/_freesurfer.py Outdated Show resolved Hide resolved
alexrockhill and others added 3 commits April 26, 2024 10:12
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmvanvliet feel free to merge if you're happy

mne/utils/docs.py Outdated Show resolved Hide resolved
larsoner and others added 2 commits April 26, 2024 13:14
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@larsoner
Copy link
Member

Okay I'll stop pushing -- you go ahead and remove the extra newline I put in! Sorry about that...

@alexrockhill
Copy link
Contributor Author

Hey a timeout failure, looks like osf might be a bit heavy traffic at the moment, should still be good to go

@wmvanvliet wmvanvliet merged commit 2448974 into mne-tools:main Apr 27, 2024
30 checks passed
@wmvanvliet
Copy link
Contributor

tnx @alexrockhill !

@alexrockhill alexrockhill deleted the fix branch April 27, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants