-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Data frame method for epochs #137
Conversation
woooottt ! that's pretty nice. I've sent you a PR with a little clean up if you want to pimp it up a bit more before we merge it would be great. |
:-) great you like it. actually i did it directly after the biomag but i wasn't sure whether to go for it.. On 07.10.2012, at 22:12, Alexandre Gramfort notifications@github.com wrote:
|
I am not scared about merging such code as it's not intrusive and most It could make a few figures with pandas kung fu before we merge it |
On 07.10.2012, at 22:18, Alexandre Gramfort notifications@github.com wrote:
:-)
the example already does some figures. its just that they aren't that nicely formatted (all the stuff done in plot_evoked, for example).
|
merging data frame edits, thanks
- more clearly demonstrating pandas hierarchical indexing - adding plotting parameters for neater plots - editing comments
you're the one to judge. an example should produce one or a few nice figures, illustrate a common
cool ! |
On 08.10.2012, at 14:26, Alexandre Gramfort notifications@github.com wrote:
have a look at my last push, wdyt?
:-)
|
example is broken due to renaming :-/ please add a description in the top docstring of what's happening |
merged by rebase after one more fix :) how do you manage to have broken examples? do you still work with python setup.py install? if so consider using : "pip install -e --user" from mne-python folder |
nope, just excessive ipython sessions... On 08.10.2012, at 23:35, Alexandre Gramfort notifications@github.com wrote:
|
Related to #133 here is a first proposal of how to interface with pandas data frames.
One important questions certainly is whether to extend support to raw and source.
What do you think?