EHN: Gat score optional epochs #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gat.fit(epochs) | ||
| assert_raises(RuntimeError, gat.score) | ||
| gat.predict(epochs) | ||
| gat.score() |
There was a problem hiding this comment.
don't refit for just testing this. It's a waste of test time
|
travis is not happy |
…crossvalidation and y is not explicitely defined
|
+1 for merge if @kingjr is happy. |
|
Happy I am |
dengemann
added a commit
that referenced
this pull request
Mar 31, 2015
EHN: Gat score optional epochs
|
Thanks @kingjr ! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmoutard @dengemann @agramfort
This is a small EHN that allows using gat.score() without passing the epochs if and only if the user has already used gat.predict().
As the object already stores the epochs predictions (in gat.y_pred_) it already possess all the necessary information which can be useful when you want to happened to have already predicted your epochs and want to test several different scorers.