Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Expanding the BEM surface when they intersect. #3785

Closed
wants to merge 2 commits into from

Conversation

jaeilepp
Copy link
Contributor

Partial fix to #3291

I was playing around with the plotter in #3778 and wanted to try this. This is how it looks for sub002 of the biomag demo.
surfaces

Before, calling make_bem_model would fail because the outer_skin is inside the outer_skull. This moves the outer_skin slightly outwards.

I'll let you decide if we want something like this.

@jaeilepp
Copy link
Contributor Author

It's probably hard to figure out from the picture since the face is punched in for anonymity. I think the expansion happened on the left side (lower left part that's sticking out a bit).

@codecov-io
Copy link

codecov-io commented Nov 23, 2016

Current coverage is 86.36% (diff: 41.17%)

Merging #3785 into master will decrease coverage by 0.01%

@@             master      #3785   diff @@
==========================================
  Files           343        343          
  Lines         61111      61121    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       9337       9342     +5   
==========================================
  Hits          52786      52786          
- Misses         5618       5627     +9   
- Partials       2707       2708     +1   

Sunburst

Powered by Codecov. Last update a85cd39...3930d30

@jaeilepp jaeilepp changed the title Expanding the BEM surface when they intersect. [WIP] Expanding the BEM surface when they intersect. Nov 24, 2016
@agramfort
Copy link
Member

I am not convinced it's the right fix. I guess many scenarios can happen depending which surface intersects with what.

@jaeilepp jaeilepp closed this Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants