-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG+2] Unify meas_date (to use a tuple) #5500
Conversation
@massich please have a look |
Codecov Report
@@ Coverage Diff @@
## master #5500 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.01%
==========================================
Files 360 360
Lines 66892 66897 +5
Branches 11317 11320 +3
==========================================
- Hits 59053 59051 -2
- Misses 5020 5024 +4
- Partials 2819 2822 +3 |
IMHO at some point, we should also rename this Line 272 in 613df87
but this can be done in a subsequent PR. |
@massich please merge when CIs are green. |
Looks great, thanks @larsoner |
Closes #5499.