Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+2] Unify meas_date (to use a tuple) #5500

Merged
merged 4 commits into from
Sep 10, 2018
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Sep 9, 2018

Closes #5499.

@agramfort
Copy link
Member

@massich please have a look

@codecov
Copy link

codecov bot commented Sep 10, 2018

Codecov Report

Merging #5500 into master will decrease coverage by <.01%.
The diff coverage is 84.84%.

@@            Coverage Diff             @@
##           master    #5500      +/-   ##
==========================================
- Coverage   88.28%   88.27%   -0.01%     
==========================================
  Files         360      360              
  Lines       66892    66897       +5     
  Branches    11317    11320       +3     
==========================================
- Hits        59053    59051       -2     
- Misses       5020     5024       +4     
- Partials     2819     2822       +3

@massich
Copy link
Contributor

massich commented Sep 10, 2018

IMHO at some point, we should also rename this _handle_meas_date function in favor of something more meaningful like _absolute_time or _meas_date_in_absolute time.

def _handle_meas_date(meas_date):

but this can be done in a subsequent PR.

@massich massich changed the title MRG: Unify meas_date [MRG+2] Unify meas_date (to use a tuple) Sep 10, 2018
@agramfort
Copy link
Member

@massich please merge when CIs are green.

@sappelhoff
Copy link
Member

Looks great, thanks @larsoner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants