MRG: Add check for comps in inv #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5610 +/- ##
==========================================
- Coverage 88.44% 88.44% -0.01%
==========================================
Files 363 363
Lines 68214 68228 +14
Branches 11526 11527 +1
==========================================
+ Hits 60332 60344 +12
- Misses 5041 5043 +2
Partials 2841 2841 |
|
+1 LGTM |
|
@agramfort okay for you? |
|
yes ok ! |
|
In it goes then, @bloyl feel free to rebase your PR to make sure everything still works there |
|
that was already merged. so we should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checking that compensation grade of data matches that of forward. If it's not the case, it's probably a (fairly easily correctable) error on the part of the user.
@bloyl do you agree?