Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG, ENH: Add proj="reconstruct" option #8033

Merged
merged 4 commits into from
Jul 22, 2020
Merged

MRG, ENH: Add proj="reconstruct" option #8033

merged 4 commits into from
Jul 22, 2020

Conversation

larsoner
Copy link
Member

Closes #3184

@larsoner
Copy link
Member Author

https://21286-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/preprocessing/plot_50_artifact_correction_ssp.html#reducing-ssp-bias-in-sensor-space-via-signal-reconstruction

agramfort
agramfort approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really neat !

I think this can dramatically change the way sensor level stats are done / affected by denoising. Also this could be applied for ICA.

thx @larsoner

@agramfort
Copy link
Member

@larsoner merge if happy

@larsoner
Copy link
Member Author

I think this can dramatically change the way sensor level stats are done

Only if we make evoked.reconstruct_proj() public, right now you can only do it in plotting ... :)

@larsoner larsoner merged commit a12cbb7 into mne-tools:master Jul 22, 2020
@larsoner larsoner deleted the reconstruct branch July 22, 2020 12:46
@agramfort
Copy link
Member

agramfort commented Jul 22, 2020 via email

@larsoner larsoner mentioned this pull request Jul 22, 2020
Open
@larsoner larsoner mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drammock drammock drammock left review comments

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Reconstruction?
3 participants
@larsoner @agramfort @drammock