MRG: Prototype of notebook viz (ipyvtk)

mne/viz/_brain/_brain.py

@@ -424,10 +424,13 @@ def __init__(self, subject_id, hemi, surf, title=None,
                                        shape=shape,
                                        fig=figure)
 
-        if _get_3d_backend() == "pyvista":
+        self.plotter = None
+        self.window = None
+        if _get_3d_backend() in ("pyvista", "notebook"):
             self.plotter = self._renderer.plotter
-            self.window = self.plotter.app_window
-            self.window.signal_close.connect(self._clean)
+            if hasattr(self.plotter, "app_window"):
+                self.window = self.plotter.app_window
+                self.window.signal_close.connect(self._clean)
 
         for h in self._hemis:
             # Initialize a Surface object as the geometry
@@ -494,11 +497,6 @@ def setup_time_viewer(self, time_viewer=True, show_traces=True):
         self.orientation = list(_lh_views_dict.keys())
         self.default_smoothing_range = [0, 15]
 
-        # setup notebook
-        if self.notebook:
-            self._configure_notebook()
-            return
-
         # Default configuration
         self.playback = False
         self.visibility = False
@@ -527,10 +525,16 @@ def setup_time_viewer(self, time_viewer=True, show_traces=True):
 
         # Direct access parameters:
         self._iren = self._renderer.plotter.iren
-        self.main_menu = self.plotter.main_menu
-        self.tool_bar = self.window.addToolBar("toolbar")
-        self.status_bar = self.window.statusBar()
-        self.interactor = self.plotter.interactor
+        if self.notebook:
+            self.main_menu = None
+            self.tool_bar = None
+            self.status_bar = None
+            self.interactor = None
+        else:
+            self.main_menu = self.plotter.main_menu
+            self.tool_bar = self.window.addToolBar("toolbar")
+            self.status_bar = self.window.statusBar()
+            self.interactor = self.plotter.interactor
 
         # Derived parameters:
         self.playback_speed = self.default_playback_speed_value
@@ -559,16 +563,20 @@ def setup_time_viewer(self, time_viewer=True, show_traces=True):
         self._configure_time_label()
         self._configure_sliders()
         self._configure_scalar_bar()
-        self._configure_playback()
         self._configure_point_picking()
-        self._configure_menu()
-        self._configure_tool_bar()
-        self._configure_status_bar()
+        if not self.notebook:
+            self._configure_playback()
+            self._configure_menu()
+            self._configure_tool_bar()
+            self._configure_status_bar()
 
         # show everything at the end
         self.toggle_interface()
-        with self.ensure_minimum_sizes():
+        if self.notebook:
             self.show()
+        else:
+            with self.ensure_minimum_sizes():
+                self.show()
 
     @safe_event
     def _clean(self):
@@ -646,10 +654,13 @@ def toggle_interface(self, value=None):
             self.visibility = value
 
         # update tool bar icon
-        if self.visibility:
-            self.actions["visibility"].setIcon(self.icons["visibility_on"])
-        else:
-            self.actions["visibility"].setIcon(self.icons["visibility_off"])
+        if not self.notebook:
+            if self.visibility:
+                self.actions["visibility"].setIcon(
+                    self.icons["visibility_on"])
+            else:
+                self.actions["visibility"].setIcon(
+                    self.icons["visibility_off"])
 
         # manage sliders
         for slider in self.plotter.slider_widgets:
@@ -779,10 +790,6 @@ def _set_slider_style(self):
                 )
                 slider_rep.GetCapProperty().SetOpacity(0)
 
-    def _configure_notebook(self):
-        from ._notebook import _NotebookInteractor
-        self._renderer.figure.display = _NotebookInteractor(self)
-
     def _configure_time_label(self):
         self.time_actor = self._data.get('time_actor')
         if self.time_actor is not None:
@@ -972,19 +979,23 @@ def _configure_point_picking(self):
         from ..backends._pyvista import _update_picking_callback
         # use a matplotlib canvas
         self.color_cycle = _ReuseCycle(_get_color_list())
-        win = self.plotter.app_window
-        dpi = win.windowHandle().screen().logicalDotsPerInch()
-        ratio = (1 - self.interactor_fraction) / self.interactor_fraction
-        w = self.interactor.geometry().width()
-        h = self.interactor.geometry().height() / ratio
+        if self.notebook:
+            dpi = 90
+            w, h = self.plotter.window_size
+        else:
+            dpi = self.window.windowHandle().screen().logicalDotsPerInch()
+            ratio = (1 - self.interactor_fraction) / self.interactor_fraction
+            w = self.interactor.geometry().width()
+            h = self.interactor.geometry().height() / ratio
         # Get the fractional components for the brain and mpl
-        self.mpl_canvas = MplCanvas(self, w / dpi, h / dpi, dpi)
+        self.mpl_canvas = MplCanvas(self, w / dpi, h / dpi, dpi,
+                                    self.notebook)
         xlim = [np.min(self._data['time']),
                 np.max(self._data['time'])]
         with warnings.catch_warnings():
             warnings.filterwarnings("ignore", category=UserWarning)
             self.mpl_canvas.axes.set(xlim=xlim)
-        if not self.separate_canvas:
+        if not self.notebook and not self.separate_canvas:
             from PyQt5.QtWidgets import QSplitter
             from PyQt5.QtCore import Qt
             canvas = self.mpl_canvas.canvas
@@ -2261,7 +2272,11 @@ def close(self):
 
     def show(self):
         """Display the window."""
-        self._renderer.show()
+        # Request rendering of the window
+        try:
+            return self._renderer.show()
+        except RuntimeError:
+            logger.info("No active/running renderer available.")
 
     def show_view(self, view=None, roll=None, distance=None, row=0, col=0,
                   hemi=None):
@@ -2928,13 +2943,6 @@ def _iter_time(self, time_idx, callback):
         # Restore original time index
         func(current_time_idx)
 
-    def _show(self):
-        """Request rendering of the window."""
-        try:
-            return self._renderer.show()
-        except RuntimeError:
-            logger.info("No active/running renderer available.")
-
     def _check_stc(self, hemi, array, vertices):
         from ...source_estimate import (
             _BaseSourceEstimate, _BaseSurfaceSourceEstimate,

mne/viz/_brain/mplcanvas.py

@@ -11,8 +11,9 @@
 class MplCanvas(object):
     """Ultimately, this is a QWidget (as well as a FigureCanvasAgg, etc.)."""
 
-    def __init__(self, brain, width, height, dpi):
+    def __init__(self, brain, width, height, dpi, notebook=False):
         from PyQt5 import QtWidgets
+        import matplotlib.pyplot as plt
         from matplotlib import rc_context
         from matplotlib.figure import Figure
         from matplotlib.backends.backend_qt5agg import FigureCanvasQTAgg
@@ -30,16 +31,21 @@ def __init__(self, brain, width, height, dpi):
             pass
         with context:
             self.fig = Figure(figsize=(width, height), dpi=dpi)
-        self.canvas = FigureCanvasQTAgg(self.fig)
-        self.axes = self.fig.add_subplot(111)
+        self.notebook = notebook
+        if self.notebook:
+            self.fig, self.axes = plt.subplots()
+            self.canvas = plt.gcf().canvas
+        else:
+            self.canvas = FigureCanvasQTAgg(self.fig)
+            self.axes = self.fig.add_subplot(111)
+            self.canvas.setParent(parent)
+            FigureCanvasQTAgg.setSizePolicy(
+                self.canvas,
+                QtWidgets.QSizePolicy.Expanding,
+                QtWidgets.QSizePolicy.Expanding
+            )
+            FigureCanvasQTAgg.updateGeometry(self.canvas)
         self.axes.set(xlabel='Time (sec)', ylabel='Activation (AU)')
-        self.canvas.setParent(parent)
-        FigureCanvasQTAgg.setSizePolicy(
-            self.canvas,
-            QtWidgets.QSizePolicy.Expanding,
-            QtWidgets.QSizePolicy.Expanding
-        )
-        FigureCanvasQTAgg.updateGeometry(self.canvas)
         self.brain = brain
         self.time_func = brain.callbacks["time"]
         for event in ('button_press', 'motion_notify') + extra_events: