ENH: multi-taper PSD estimation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # define frequencies of interest | ||
| fmin, fmax = 0., 70. | ||
| bw = 4. # bandwidth of the windows in Hz |
There was a problem hiding this comment.
can you use bandwidth rather than bw?
There was a problem hiding this comment.
Ok. Any objections if I change the parameter name to "bandwidth" as well?
|
besides this looks good to me ! |
|
can you rebase so the PR can be merged nicely with the green button? |
|
Rebased. The NW issue was confusing. Apparently dpss_windows() expected NW to be the standardized half-bandwidth but then "Kmax" is wrong. I fixed this and opened a PR in nitime nipy/nitime#105 One problem is that the tests will fail unless you use nitime with my PR included.. |
|
merging ! I guess we'll have a failing test for a few days... |
agramfort
added a commit
that referenced
this pull request
Sep 7, 2012
ENH: multi-taper PSD estimation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-taper PSD estimation, direct and for MNE-type inverse methods in source space.
The functions for the DPSS window computation were copied from nitime with some minor modifications. The PSD computation was optimized s.t. it requires less memory and is faster than the nitime version: When adaptive weights are used, the tapered spectra are combined directly instead of first returning the weights (~50% memory saving), in addition, parallel processing can be used to speed up the computation.