New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed length epochs overlap #9096
Fixed length epochs overlap #9096
Conversation
e234d91
to
b8282d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just add a what's new entry?
thx @sfc-neuro !
@sfc-neuro can you quickly push a what's new entry so we can move on here? thanks |
…n and written the consequent test in test_epochs
1bb7724
to
1af0432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green
Thanks @sfc-neuro! |
Reference issue
Fixes #8773.
What does this implement/fix?
Adds compatibility for the overlap parameter in the function make_fixed_length_epochs
Additional information
Tests were also added to test the new feature inspired by the pre-existing ones written for make_fixed_length_events.