[BUG, MRG] Fix tutorial + example show_view to use correct keyword args #9599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes sense, to be safe can you make sure you touch/change all six failed examples in https://app.circleci.com/pipelines/github/mne-tools/mne-python/9192/workflows/843a1e8e-b046-48bc-9909-908f9b29b317/jobs/31440 EDIT: so that CircleCI runs and we make sure the errors are gone |
larsoner
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
LGTM, will merge once CircleCI comes back happy. Thanks for the quick fix @alexrockhill !
| @@ -280,8 +279,7 @@ def plot_approach(power, n): | |||
| brain.add_foci(vertices[0][0], coords_as_verts=True, hemi='lh', color='b') | |||
| brain.add_foci(vertices[1][0], coords_as_verts=True, hemi='rh', color='b') | |||
| # Rotate the view and add a title. | |||
| brain.show_view(view={'azimuth': 0, 'elevation': 0, 'distance': 550, | |||
| 'focalpoint': [0, 0, 0]}) | |||
| brain.show_view(azimuth=0, elevation=0, distance=550, focalpoint=(0, 0, 0)) | |||
|
@larsoner, do you know what's going on with this failed test? |
|
Looks unrelated to your changes, I'm guessing it's VTK 9.0.3's fault. I'll open a PR to try to fix it |
|
Thanks @alexrockhill ! |
marsipu
pushed a commit
to marsipu/mne-python
that referenced
this pull request
Aug 2, 2021
…gs (mne-tools#9599) * fix tutorial + example show_view * clean up paths to touch examples * seg fault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #9598.
Also if there were two hemispheres but the same view, it would do the depreciation warning so I fixed that.