Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add config var for opt-in #9955

Merged
merged 1 commit into from Nov 4, 2021
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Nov 4, 2021

From talking to @marsipu and @hoechenberger and running some OpenGL tests, we decided using OpenGL with the PyQtGraph backend should be opt-in. (TL;DR: Maintenance burden; OpenGL totally breaks things on my macOS machine; it's slower than CPU on my Linux machine with a good graphics card.) To facilitate this, we should have a MNE_BROWSE_USE_OPENGL config var, as it makes sense generally to have this set on a machine-by-machine basis / shouldn't really need to be set often (at all?) on a script-by-script basis.

Once this is merged, I can make a PR to mne-qt-browser to change the behavior:

  1. Only try to use OpenGL if MNE_BROWSE_USE_OPENGL=true (otherwise use CPU)
  2. If requested, then try importing PyOpenGL
  3. If not found, emit a warning that it was requested but couldn't be used, and resort to CPU rendering

@drammock @agramfort feel free to merge if you agree with this plan

@larsoner larsoner merged commit 67c7f3e into mne-tools:main Nov 4, 2021
@larsoner larsoner deleted the opt-in branch November 4, 2021 14:07
@larsoner larsoner mentioned this pull request Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants