Propagate any errors occurring within the _BaseClient context
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems fair to me. Any possibility of adding a test? |
|
Thanks @jasmainak ! Added a test to check that the error gets propagated up to the user. |
…ser track down where an error came from.
charlesbmi
force-pushed
the
client-exit-propagate-error
branch
from
16fb949
to
19320f2
Compare
|
Looks like this uncovered a real bug in our code/test: maybe it just needs a |
…n_samples, but sfreq * n_secs * 2 is (often) a float
|
@larsoner I pushed 4c82e98 to fix that bug in After fixing the (And then the test freezes and requires a FYI in case it matters, I am running on macOS. |
Sounds like it's sending more data than we need. In theory you should be able to tell it to mock a shorter file or set some timeout in a MNE-Realtime object to get it to timeout or something. See if there's anything like that, and if not I'll take a look. Really it shouldn't be your problem to have to fix so don't feel obligated to spend too much time on it... |
|
@charlesincharge You want @larsoner not me |
|
ah, sorry about that! |
charlesbmi
force-pushed
the
client-exit-propagate-error
branch
from
3477d73
to
e439219
Compare
…nfinite generator, so it is not possible to convert to a list
|
e439219 should fix this error: And then the test was subsequently froze on |
larsoner
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior: any Exceptions occurring within a
_BaseClientcontext exit the context but do not propagate any errors.From https://docs.python.org/3/reference/datamodel.html#with-statement-context-managers about
__exit__:(Note that
return selfacts as a true value here)New behavior: Exceptions are propagated through the context.
This helps user track down where an error came from.