Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of mne-realtime #56

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Deprecation of mne-realtime #56

merged 9 commits into from
Oct 17, 2023

Conversation

mscheltienne
Copy link
Member

@mscheltienne mscheltienne commented Oct 16, 2023 •
edited
Loading

Add warning to readme and doc/index redirecting to mne-lsl.
Closes mne-tools/mne-lsl#159

mscheltienne
mscheltienne commented Oct 16, 2023
View reviewed changes
doc/index.rst Outdated Show resolved Hide resolved
@mscheltienne
Copy link
Member Author

@larsoner Happy with the deprecation messages?

larsoner
larsoner reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but to really drive the point home we should also warnings.warn(..., FutureWarning, stacklevel=2) or so in mne_realtime/__init__.py.

setup.py Show resolved Hide resolved
@mscheltienne
Copy link
Member Author

That should cover it. Should we do a release of mne-realtime just to have the warning in?

@larsoner larsoner merged commit 6751569 into mne-tools:main Oct 17, 2023
8 checks passed
@larsoner
Copy link
Member

https://pypi.org/project/mne-realtime/0.3.0/

@mscheltienne mscheltienne deleted the deprecation branch October 17, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document deprecation of mne-realtime
2 participants
@mscheltienne @larsoner