Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in reporting sectors #180

Closed
wants to merge 1 commit into from
Closed

Conversation

pstray
Copy link

@pstray pstray commented Jan 28, 2022

A small fix to fix a python error.

@frbor
Copy link
Member

frbor commented Jan 28, 2022

I do not think this is a bug. sectors contains two lists, sectors and unknown_sectors:

   "sectors": {    
       "sectors": [   
           "finance"    
       ],    
       "unknown_sectors": []
   }

See https://github.com/mnemonic-no/act-workers/blob/master/test/scio-doc.json for an example scio document.

@frbor frbor self-requested a review January 28, 2022 11:41
@frbor frbor self-assigned this Jan 28, 2022
@pstray
Copy link
Author

pstray commented Jan 28, 2022

That may be what it should have been, but it was definitely just a list.... without that patch, it dies with the following error-message:

AttributeError: 'list' object has no attribute 'get'

@frbor
Copy link
Member

frbor commented Jan 28, 2022

I'm sorry for the confusion, but I do think this errors occurs when the old act-scio, which is documented in the act documentation repos, is used (instead of act-scio2 which is a reimplemntation of scio).

We will update the doc to point to act-scio2.

@frbor frbor closed this Jan 28, 2022
@pstray
Copy link
Author

pstray commented Jan 28, 2022

That seems like a likely cause. Maybe the doc format should have a version field so this kind of bugs could be handled more gracefully ;)

@pstray pstray deleted the sectors-fix branch January 28, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants