Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: make Google Translate and Google Text to Speech optimal dependencies #200

Closed
LuckyTurtleDev opened this issue Sep 8, 2021 · 6 comments

Comments

@LuckyTurtleDev
Copy link
Contributor

LuckyTurtleDev commented Sep 8, 2021

I think many users did not need this features. Furthermore the associated packages python:googletrans and python:gtts are not part of many linux distributions.
It would also be much easier to create and maintain a mnemosyne package, so mnemosyne will hopeful be available at more distributions.
Some distribution like debian has already apply their own patches to disable this features.

Because of this I would be nice if this packages will be only optimal.

@pbienst
Copy link
Contributor

pbienst commented Sep 8, 2021

Whether or not many people use these features is of course a matter of debate :-)

I do believe it's the responsibility of the distributions here to take any actions they see fit, rather than Mnemosyne having to cater to the common denominator.

@pbienst pbienst closed this as completed Sep 8, 2021
@alexdewar
Copy link

@pbienst Hi! Thanks for producing Mnemosyne :-)

I'm the maintainer for the Arch Linux AUR package. The issue we're having at the moment is that the googletrans package is broken, which unfortunately also means that users cannot install or use Mnemosyne, regardless of whether or not they want this functionality. Mnemosyne currently won't start without this package being present. It could most easily be made optional by turning this fatal error into a warning instead (i.e. wrapping the import googletrans in a try/except block. I'm happy to put in a PR if you don't have time.

@LuckyTurtleDev
Copy link
Contributor Author

LuckyTurtleDev commented Sep 9, 2021

I have created a pull request, which does make both optional: #201

@pbienst
Copy link
Contributor

pbienst commented Sep 9, 2021

Thanks, I have committed it, but I wouldn't be surprised if in the future we get support requests about why these features are not present, since there's not even a console warning message now...

@LuckyTurtleDev
Copy link
Contributor Author

I can add a warning, if you wish. That is no problem.

@alexdewar
Copy link

Thanks both. That's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants