-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember how many cards we've learned today even after re-opening the app #110
Merged
pbienst
merged 9 commits into
mnemosyne-proj:master
from
woohgit:remember-today-learned-count
Mar 3, 2019
Merged
Remember how many cards we've learned today even after re-opening the app #110
pbienst
merged 9 commits into
mnemosyne-proj:master
from
woohgit:remember-today-learned-count
Mar 3, 2019
Commits on Feb 23, 2019
-
Remember how many cards we learned today
When we close the mnemosyne application and re-open it, it won't remember the number of the already memorized cards. In other words, it won't warn you if you've already learned 15 or more words. This PR aims to fix this issue and re-construct the `self._fact_ids_memorised` from the logs. We can fetch all the newly learned cards and all the forgotten but learned cards today. Combining the two, we can get the number of the learned cards today.
Configuration menu - View commit details
-
Copy full SHA for b3a3f2d - Browse repository at this point
Copy the full SHA b3a3f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17b8f3a - Browse repository at this point
Copy the full SHA 17b8f3aView commit details
Commits on Feb 25, 2019
-
Fix edge case of calling reset and getting an alert
When saving the Settings dialog, the `reset` is alwas called, so it would trigger an alert every time when, because during the reset function, the `warned_about_too_many_cards` is reset to `warned_about_too_many_cards = False`. This fix initializes the `warned_about_too_many_cards` on the class level, and calling `reset` won`t reset it back to `False`. Also only warn when we've just reached the 15 new or forgotten words.
Configuration menu - View commit details
-
Copy full SHA for 7639d5f - Browse repository at this point
Copy the full SHA 7639d5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c7f89f - Browse repository at this point
Copy the full SHA 0c7f89fView commit details -
Add a new event type: `WARNED_TOO_MANY_CARDS` so we can query from the log table if the warning has been already shown or not. - Add test coverage
Configuration menu - View commit details
-
Copy full SHA for 9b2f9ad - Browse repository at this point
Copy the full SHA 9b2f9adView commit details -
Don't need to warn on start-up
Warning on start-up would be only useful if we could alert more than once a day. If we already displayed a warning, we should never show the warning again on start-up.
Configuration menu - View commit details
-
Copy full SHA for 639fa7f - Browse repository at this point
Copy the full SHA 639fa7fView commit details -
Python lists are unordered, so comparing them will result in a random result. Using `sort()` will ensure that the elements are ordered so we can compare them properly. Using sort is `O(n log n)`.
Configuration menu - View commit details
-
Copy full SHA for 849445e - Browse repository at this point
Copy the full SHA 849445eView commit details
Commits on Mar 2, 2019
-
- Move sql queries to the database class - Add test coverage for the new database API functions - adjusting the variable naming to comply with the current naming scheme
Configuration menu - View commit details
-
Copy full SHA for 58204e0 - Browse repository at this point
Copy the full SHA 58204e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff01df7 - Browse repository at this point
Copy the full SHA ff01df7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.