pagination fix plus list with subitems #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexP007
reviewed
Mar 26, 2021
lib/functions.php
Outdated
| @@ -51,4 +50,32 @@ function renderHtml(callable $fn, string ...$strs): void { | |||
| // принимает строку и список "запретных" слов, которые будут вырезаны | |||
| function cleanStr(string $str, string ...$args): string { | |||
| return str_replace($args, '', $str); | |||
| } | |||
|
|
|||
| function renderHtmlList($list) { | |||
There was a problem hiding this comment.
да, отличный вопрос))
| $result = '<ul>'; | ||
|
|
||
| // хотелось через foreach, но по разметке не валидно получается | ||
| // foreach ($list as $item) { |
There was a problem hiding this comment.
точно можно через foreach, только надо кое-где инициализацию result и условия поменять)
| @@ -1,6 +1,9 @@ | |||
| <?php | |||
| $pageNumber = $_GET['page'] ?? 1; | |||
| const POSTS_PER_PAGE = 5; | |||
|
|
|||
| $arr = array_chunk($posts, POSTS_PER_PAGE); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.