Added track width as optional props #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, I'll take a look shortly! |
mnkhouri
reviewed
Nov 29, 2023
| @@ -22,7 +22,8 @@ | |||
| "postpublish": "PACKAGE_VERSION=$(echo 'const p = require(\"./package.json\"); process.stdout.write(p.version)' | node) && git tag v$PACKAGE_VERSION && git push --tags", | |||
| "test": "eslint src/** && prettier --check src/**", | |||
| "build": "rm -rf ./dist ./docs && prettier --write src/** docs-src/** && webpack && tsc", | |||
| "watch-docs": "webpack serve" | |||
| "watch-docs": "webpack serve", | |||
| "prepare": "npm run build" | |||
There was a problem hiding this comment.
From reading the docs for prepare, I see that it runs on install and prepublish. Since there's already a prepublishOnly script that runs a build, this prepare will just add a build at install time.
However, I don't think consumers of this library generally need to run build at install time, since the built version should already be included (as part of the prepublishOnly during publishing the new version). What do you think?
There was a problem hiding this comment.
prepare is a nice addition, doesn't hurt anyone
Closed
|
Thanks for the contribution! |
|
Published as v0.3.0 at https://www.npmjs.com/package/react-circular-slider-svg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed the ability to set the width of the circle, i.e. track width, via props.
Pls consider including this feature in the next version.