Support for hover over image or location

In Sikuli, sometimes clicks does not work in Graphics Area, the solution for this is to first hover, wait and then click as specified here RaiMan/SikuliX-2014#260 So adding support for hover command
mnkjadhav · Dec 28, 2017 · 650aa74 · 650aa74
1 parent 7b2adab
commit 650aa74
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 9 deletions.
diff --git a/SikuliSharp.Tests/EndToEndTests.cs b/SikuliSharp.Tests/EndToEndTests.cs
@@ -49,7 +49,11 @@ public void CanRunSikuliCommands()
 
 					Assert.That(session.Exists(greenLabelPattern), Is.False, "Green label should not exist yet");
 
-					Assert.That(session.Click(testButtonPattern), Is.True, "Click on test button");
+                    Assert.That(session.Hover(testButtonPattern), Is.True, "Hover over Test Button");
+
+                    Assert.That(session.Hover(new Location(appLocation.X + 350, appLocation.Y + 100)), Is.True, "Hover outside Test Button");
+
+                    Assert.That(session.Click(testButtonPattern), Is.True, "Click on test button");
 
 					Assert.That(session.Exists(greenLabelPattern), Is.False, "Green label should still not exist (a 5s timer is shown)");
 

diff --git a/SikuliSharp.Tests/Unit/SikuliSessionTests.cs b/SikuliSharp.Tests/Unit/SikuliSessionTests.cs
@@ -63,7 +63,21 @@ public IEnumerable<CommandTestData> CommandsTestSource
 					// ReSharper disable once RedundantArgumentDefaultValue
 					Method = (session, pattern) => session.WaitVanish(pattern, 0f)
 				};
-			}
+
+                yield return new CommandTestData
+                {
+                    Timeout = 0f,
+                    ExpectedCommand = "print \"SIKULI#: YES\" if hover(::PATTERN::) else \"SIKULI#: NO\"",
+                    Method = (session, pattern) => session.Hover(pattern)
+                };
+
+                yield return new CommandTestData
+                {
+                    Timeout = 0f,
+                    ExpectedCommand = "print \"SIKULI#: YES\" if hover(::PATTERN::.targetOffset(0, -100)) else \"SIKULI#: NO\"",
+                    Method = (session, pattern) => session.Hover(pattern, new Point(0, -100))
+                };
+            }
 		}
 
 		[SetUp]
@@ -134,8 +148,8 @@ public IEnumerable<string> InvalidTypeTestSource
 			}
 		}
 
-		[Test, TestCaseSource("InvalidTypeTestSource"), ExpectedException(typeof(ArgumentException))]
-		public void TypeWithInvalidTextThrows(string text)
+        [Test, TestCaseSource("InvalidTypeTestSource"), ExpectedException(typeof(ArgumentException))]
+        public void TypeWithInvalidTextThrows(string text)
 		{
 			_session.Type(text);
 		}

diff --git a/SikuliSharp/SikuliSession.cs b/SikuliSharp/SikuliSession.cs
@@ -13,7 +13,9 @@ public interface ISikuliSession : IDisposable
 		bool Wait(IPattern pattern, float timeoutInSeconds = 0);
 		bool WaitVanish(IPattern pattern, float timeoutInSeconds = 0);
 		bool Type(string text);
-	}
+        bool Hover(IPattern pattern);
+        bool Hover(IPattern pattern, Point offset);
+    }
 
 	public class SikuliSession : ISikuliSession
 	{
@@ -75,7 +77,17 @@ public bool Type(string text)
 			return result.Contains("SIKULI#: YES");
 		}
 
-		protected bool RunCommand(string command, IPattern pattern, float commandParameter)
+        public bool Hover(IPattern pattern)
+        {
+            return RunCommand("hover", pattern, 0);
+        }
+
+        public bool Hover(IPattern pattern, Point offset)
+        {
+            return RunCommand("hover", new WithOffsetPattern(pattern, offset), 0);
+        }
+
+        protected bool RunCommand(string command, IPattern pattern, float commandParameter)
 		{
 			pattern.Validate();
 
@@ -98,8 +110,6 @@ private static string ToSukuliFloat(float timeoutInSeconds)
 		public void Dispose()
 		{
 			_runtime.Stop();
-		}
-
-
+		}        
     }
 }