Fixes piranhacloud#3736 - Move Netty dependency version into its Pira…

…nha HTTP module
mnriem · May 27, 2024 · cba993b · cba993b
1 parent 58c3fc4
commit cba993b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 62 deletions.
diff --git a/COMPONENTS.md b/COMPONENTS.md
@@ -1,6 +1,9 @@
+# Components
+
 | Name                  | Version       |
 |-----------------------|---------------|
 | Eclipse Grizzly       | 4.0.2         |
 | Eclipse Grizzly NPN   | 2.0.0         |
-| RedHat Weld           | 5.1.2.Final   |
+| Netty                 | 4.1.108.Final |
 | RedHat Undertow       | 2.3.12.Final  |
+| RedHat Weld           | 5.1.2.Final   |
diff --git a/http/netty/pom.xml b/http/netty/pom.xml
@@ -13,7 +13,9 @@
     <packaging>jar</packaging>
 
     <name>Piranha - HTTP - Netty Integration</name>
-
+    <properties>
+        <netty.version>4.1.108.Final</netty.version>
+    </properties>
     <dependencies>
         <!-- compile -->
         <dependency>
@@ -25,21 +27,25 @@
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-buffer</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-codec-http</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-codec-http2</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
         <dependency>
             <groupId>io.netty</groupId>
             <artifactId>netty-transport</artifactId>
+            <version>${netty.version}</version>
             <scope>compile</scope>
         </dependency>
         <!-- test -->

diff --git a/pom.xml b/pom.xml
@@ -97,7 +97,6 @@
         <maven-plugin-api.version>4.0.0-alpha-13</maven-plugin-api.version>
         <maven-plugin-tools-annotations.version>3.11.0</maven-plugin-tools-annotations.version>
         <microprofile-jwt-auth.version>2.0.2</microprofile-jwt-auth.version>
-        <netty.version>4.1.108.Final</netty.version>
         <omnibeans.version>0.3</omnibeans.version>
         <omniservices.version>0.4</omniservices.version>
         <omniutils.version>0.13</omniutils.version>
@@ -390,39 +389,7 @@
                 <artifactId>hazelcast</artifactId>
                 <version>${hazelcast.version}</version>
             </dependency>
-
-            <!-- Netty -->
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-buffer</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-codec-http</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-codec-http2</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-common</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-handler</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-            <dependency>
-                <groupId>io.netty</groupId>
-                <artifactId>netty-transport</artifactId>
-                <version>${netty.version}</version>
-            </dependency>
-
+
             <!-- OmniFaces Beans -->
             <dependency>
                 <groupId>ee.omnifish</groupId>

diff --git a/test/debug/pom.xml b/test/debug/pom.xml
@@ -526,32 +526,6 @@
             <artifactId>hazelcast</artifactId>
         </dependency>
 
-        <!-- Netty -->
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-buffer</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-codec-http</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-codec-http2</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-common</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-handler</artifactId>
-        </dependency>
-        <dependency>
-            <groupId>io.netty</groupId>
-            <artifactId>netty-transport</artifactId>
-        </dependency>
-
         <!-- OmniFaces Config -->
         <dependency>
             <groupId>org.omnifaces</groupId>