Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with components install #14

Closed
hstanleycrow opened this issue Sep 4, 2015 · 9 comments
Closed

Issue with components install #14

hstanleycrow opened this issue Sep 4, 2015 · 9 comments

Comments

@hstanleycrow
Copy link

Hi, first, thanks for your work.
I am making some tests, and the installer works in a half, the components (jquery, jqueryui, font-awesome) has been installed on vendor directory, bootstrap, bootstrap-sass and datatables are installes as i expected, in root/resources, could you help me to find the error? if i can fix this, i will not require to use bower or anything else :)

here is my composer.json
"require" : {
"php": ">=5.3.0",
"mnsami/composer-custom-directory-installer": "1.0.*",
"components/jqueryui" : ">=1.11.4",
"components/font-awesome" : "dev-master",
"twbs/bootstrap-sass" : ">=3.3.5",
"twbs/bootstrap" : "~4.0",
"datatables/datatables" : ">=1.10.9"
},
"config": {
"preferred-install": "dist"
},
"extra": {
"installer-paths": {
"public/resources/components/jqueryui": ["components/jqueryui"],
"public/resources/components/font-awesome": ["components/font-awesome"],
"public/resources/bootstrap": ["twbs/bootstrap"],
"public/resources/bootstrap-sass": ["twbs/bootstrap-sass"],
"public/resources/datatables": ["datatables/datatables"]
}
},
"minimum-stability": "dev",
"prefer-stable": true

Thank you

@mnsami
Copy link
Owner

mnsami commented Sep 20, 2015

hello .. sorry for the late reply, but currently i'm heading off to my wedding vacations and i'll be available again after the 14th of October and I'll look into deep for all the comments you asked and pointed out.

thanks

@mnsami
Copy link
Owner

mnsami commented Feb 1, 2016

Hello @hstanleycrow

Simply all of those packages you want to custom install them, doesn't have the right package type that is supported by composer, which are mentioned here

https://getcomposer.org/doc/04-schema.md#type

@Mariyo
Copy link

Mariyo commented Apr 25, 2016

Hello,
isnt there any workaround for unsupported types? Kind of skip process...?

@mnsami
Copy link
Owner

mnsami commented Apr 26, 2016

hello @Mariyo ,

Unfortunately not at the current moment, unless you fork it and implement your own package type installer and plugin, which do the support for very specific package types.

I'm happy to discuss a solution, because it will also affect composer workflows.

@mnsami
Copy link
Owner

mnsami commented May 19, 2016

Reporter is not responding, I'm closing the ticket.

@mnsami mnsami closed this as completed May 19, 2016
@sylfabre
Copy link

@mnsami I would like to discuss a solution :-)
I use your plugin to put jquery / jqueryui / ckeditor in a public folder

@sylfabre
Copy link

@mnsami I don't understand why you limit depending on package type and not on installer-paths values to select package with specific location

@mnsami
Copy link
Owner

mnsami commented Jun 1, 2016

@sylfabre hello, I would like to hear your solution, and to answer your question, each package type composer handles it differently, I experienced that myself and I don't want to break that handling, my aim through this plugin is to extend it.

Let me give you an example, some of the pear packages are initially a tar or a zip file which I tried before, if I used them with a different package type, they will be only downloaded and not extracted.

Second, if all package types are the same, I don't think composer would have differentiated them in first place.

Check also the https://packagist.org/packages/composer/installers plugin.

@sylfabre
Copy link

sylfabre commented Jun 1, 2016

@mnsami I don't know how composer works exactly si I don't know about packages that need to be extracted first but I will use robloach/component-installer to set my specific path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants