Skip to content
This repository has been archived by the owner on May 12, 2023. It is now read-only.

Set dynamic height with fadeIn true #290

Merged
merged 4 commits into from Oct 4, 2020

Conversation

andrelmlins
Copy link
Contributor

Hello @moaazsidat and @renatobenks , great library, congratulations.

I cannot set the camera height when using fadeIn. What do you think of this solution?

@andrelmlins
Copy link
Contributor Author

Hi there, any news?

Copy link
Collaborator

@renatobenks renatobenks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, it means a lot!

index.js Outdated Show resolved Hide resolved
@renatobenks renatobenks merged commit 43e9eed into moaazsidat:master Oct 4, 2020
@andrelmlins
Copy link
Contributor Author

Thanks @renatobenks, when will a new version be created?

@renatobenks
Copy link
Collaborator

renatobenks commented Oct 5, 2020

that's a hard one @andrelmlins, because the process to release new versions at npm is not automated, and I need of @moaazsidat to publish it, and he's not so available to do that lately. Try to play with this version from the commit reference on npm!

But what I'm trying to move forward with is to automate that process to avoid this dependency for good.

@andrelmlins
Copy link
Contributor Author

andrelmlins commented Oct 5, 2020

Ok @renatobenks , thanks very much, if you need help i can do a PR for automation scripts.

@github-actions
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants