Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recipe url from ssh git url repo #11

Merged
merged 1 commit into from
Jul 12, 2018
Merged

fix recipe url from ssh git url repo #11

merged 1 commit into from
Jul 12, 2018

Conversation

lainosantos
Copy link
Contributor

The version 1.0.0 has a bug, when a repo url is git@${server}:${repo}.git it causes a error on https://github.com/lainosantos/symfony-flex-server/blob/d07a0ef5371413e6c404d7563342545aeb531c5c/assets/js/dashboard.js#L100, because https://github.com/lainosantos/symfony-flex-server/blob/d07a0ef5371413e6c404d7563342545aeb531c5c/assets/js/dashboard.js#L96 doesn't set value to repoUrl var.

This merge adds too the new parameter 'enable_https_private_recipe', for private repos, like gitlab, that have ssh repo url, but not have https protocol enabled.

@moay
Copy link
Owner

moay commented Jul 12, 2018

Hi there. :-) Thanks for your input!

About the issues:

git@${server}:${repo}.git is not a valid url, it should be git@${server}:${user}/${repo}.git - or am I wrong? L96 does set the https url to repoUrl if the pattern is matched, which it should be with your url structure. Ist this an actual error that happened to you? Could you provide debugging information like screenshots, the git url used, and so? Feel free to send me an email to mv@moay.de if there is confidential information.

The caching part and the https enable private part should be separate issues and get their own branch with their own PRs in order to not mixup things and handle issues separately. Would you mind splitting that up?

Thanks!

@lainosantos
Copy link
Contributor Author

Hi :) This is a great project.

Yes, you are right, the ssh repo url is git@${server}:${user}/${repo}.git, example: i'm using a private gitlab instance and the private repo url is git@gitlab:symfony/recipes.git.

I cleaned up this PR to only fix #13.

Thanks

Copy link
Owner

@moay moay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's absolutely correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants