Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a null check to TMPro sprite asset material checking #176

Conversation

Oskiii
Copy link

@Oskiii Oskiii commented Jul 4, 2019

If the Sprite Asset has not been set in TMPro settings, there is an error which prevents UIEffect from drawing its TMPro warning. This pull request adds a null-check to prevent such error.

Reproducing bug:

  • Use UIEffect normally, but make sure that the SpriteAsset field in TMPro Settings is empty
  • Selecting the text object with UIEffect causes an error

@mob-sakai mob-sakai added the bug label Jul 4, 2019
@mob-sakai
Copy link
Owner

Hi @Oskiii
Thank you for your PR!

@mob-sakai mob-sakai merged commit 79534a8 into mob-sakai:develop Jul 4, 2019
@mob-sakai mob-sakai added this to the v3.2.0 milestone Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants