Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Convert the new osu!beatmap links to the old one as a workaround #47

Merged
merged 5 commits into from
Mar 22, 2022

Conversation

touanu
Copy link
Contributor

@touanu touanu commented Feb 13, 2022

This makes osumer detect the new format of osu!beatmap ("https://osu.ppy.sh/beatmapsets" and "https://osu.ppy.sh/beatmaps")
Also fix "Could not connect or add queue to daemon" issue when trying to download a map from game at Daemon.java

Remove "jackson" jar from osumer-setup.vdproj

@SuperMario22922
Copy link

Could I please have an installer for this

@touanu
Copy link
Contributor Author

touanu commented Feb 16, 2022

Could I please have an installer for this

You can get it from my repo

@SuperMario22922
Copy link

Thank you so much for this!

@mob41
Copy link
Owner

mob41 commented Feb 16, 2022

@touanu sorry for abandoning this project for years. I will look into your pull request and merge it asap thxx!

@touanu
Copy link
Contributor Author

touanu commented Feb 17, 2022

that would be nice :D

@mob41
Copy link
Owner

mob41 commented Feb 22, 2022

I think it is okay. But the problem is we need to update the build version that is hard-coded in Osumer.java and osumer-setup.vdproject

https://github.com/mob41/osumer/blob/master/pom.xml
- global.build to 11
https://github.com/mob41/osumer/blob/master/osumer-lib/src/main/java/com/github/mob41/osumer/Osumer.java
- OSUMER_BUILD_NUM to 11
https://github.com/mob41/osumer/blob/master/osumer-setup/osumer-setup.vdproj
- ProductVersion to 8:2.0.11

I think it is time for me to tidy up the repository for future contribution though. IMO, I am not really satisified with the code style that I had over 5 years ago. It needs to be momre documented and tidied.

After modifying these parameters, releasing the new setup, and updating the https://github.com/mob41/osumer-updater/blob/gh-pages/versions.json, update can be distributed to clients.

I can update the the json file and release the setup for you, but the parameters you might need to help me to change because it's in your fork. Thanks alot !

@touanu
Copy link
Contributor Author

touanu commented Feb 27, 2022

Updated it :D

@mob41 mob41 merged commit da5a562 into mob41:master Mar 22, 2022
@mob41
Copy link
Owner

mob41 commented Mar 22, 2022

Sorry for late reply. Thanks a lot! I will release to GitHub soon.

@mob41
Copy link
Owner

mob41 commented Mar 23, 2022

Released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants