Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update MetaData for IVORY COAST #93

Closed
wants to merge 6 commits into from
Closed

Chore: Update MetaData for IVORY COAST #93

wants to merge 6 commits into from

Conversation

hkairi
Copy link

@hkairi hkairi commented Feb 26, 2021

No description provided.

@joshwetzel
Copy link
Contributor

Hello! Thanks for submitting this pull request.

Did you pull these changes directly from our upstream (https://github.com/google/libphonenumber)? If so, were other changes excluded?

@hkairi
Copy link
Author

hkairi commented Mar 2, 2021

Hello

Did you pull these changes directly from our upstream (https://github.com/google/libphonenumber) -- Yes

I only took changes for IVORY COAST ( country_code="CI" )

@joshwetzel
Copy link
Contributor

Is data/telephone_number_data_file.dat correct? I'm seeing a diff when I generate it using your XML.

@hkairi
Copy link
Author

hkairi commented Mar 2, 2021

data/telephone_number_data_file.dat is correct. I am using it in my application right now and the validation is working as expected.

@joshwetzel
Copy link
Contributor

Thanks for your patience. We will include these changes as part of a larger metadata update rather than cutting a new release specifically for this. It is something I plan on working on next week.

@joshwetzel
Copy link
Contributor

These updates were included with #95. Thanks again for your patience.

@joshwetzel joshwetzel closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants