Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove section titles and comments from JSON output #55

Merged
merged 1 commit into from
Mar 17, 2014
Merged

Remove section titles and comments from JSON output #55

merged 1 commit into from
Mar 17, 2014

Conversation

paldepind
Copy link
Contributor

Similar to my previous commit. The comment syntax is not proper JSON and the standard JavaScript JSON parser can't handle it.

At a glance I can't see what the printed_section variable is for so I just let it be. Also a line break will still be printed between sections which is good.

The comment syntax is not proper JSON.
@scelis scelis merged commit 7e311c7 into scelis:master Mar 17, 2014
@scelis
Copy link
Owner

scelis commented Mar 17, 2014

Thanks again! I noticed this (and the previous commit) broke a couple unit tests. Those have been fixed in a0a8496.

I also cleaned up the output slightly and removed the very first blank line after the initial opening brace in 14036f2

@paldepind
Copy link
Contributor Author

Splendid! Thanks for the quick response time and for taking your time to integrate these pull requests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants