Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Modern eslint ES5 compatibility #116

Merged
merged 7 commits into from
Aug 4, 2016
Merged

Modern eslint ES5 compatibility #116

merged 7 commits into from
Aug 4, 2016

Conversation

DanielleB-R
Copy link
Contributor

@DanielleB-R DanielleB-R commented Aug 3, 2016 •
edited by marlowpayne
Loading

Changes

  • Add an ESLint 2+ compatible version of the ES5 linting standard in the es5 directory
  • Modify the instructions to use it.
  • Fixes #115
  • Fixes #106
  • Fixes #50

How To Test

  • Update grunt-eslint in a repository to the latest version
  • Follow the migration instructions in the new README.md
  • Run the linter and see that it works.

Applicable Research Resources

  • (links, optional)

TODOs:

  • +1
  • Updated README
  • Updated CHANGELOG

marlowpayne
marlowpayne reviewed Aug 3, 2016
View reviewed changes
README.md
@@ -24,20 +36,36 @@ eslint:{
// When true, eslint will test _only_ the rules set in the provided
// configuration file
reset: false,
config: 'node_modules/mobify-code-style/javascript/.eslintrc'
config: './.eslintrc.yml'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix #50 while we're here and update the key name to configFile

@marlowpayne
Copy link

Just want to point out that extending from eslint:recommended will enable the no-unused-vars rule. This is a bit of an issue with previous Adaptive builds, as discussed in #78

@marlowpayne
Copy link

Also pointing out that eslint:recommended turns on the no-console rule.

@DanielleB-R
Copy link
Contributor Author

I'll just remove eslint:recommended since for any new project we probably want to use ES6 anyways.

@marlowpayne
Copy link

Thanks for these changes @DanielBrookRoberge ! Tested on a couple Adaptive projects. 👍

@DanielleB-R DanielleB-R merged commit bd23862 into develop Aug 4, 2016
@DanielleB-R DanielleB-R deleted the modern-eslint-es5-compatibility branch August 4, 2016 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@MikeKlemarewski MikeKlemarewski

@mikenikles mikenikles

@marlowpayne marlowpayne

Labels
Ready for Review
Milestone
No milestone
4 participants
@DanielleB-R @marlowpayne @MikeKlemarewski @mikenikles