This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Remove linebreak-style Rule for ES6
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some developers have reported issues with their linter reporting errors for line endings. This is because we have our style set to
unix. This works fine with unix obviously and macos, but it doens't play well with windows users unless they make changes to their IDE settings. Getting them to make those changes is probably more hassle than it's worth. So we have decided to remove this rule.We are going to make this change in conjunction with adding a gitattributes file to our scaffold to allow autoconvertion for the file line endings as recommended here
Linked PRs: (387)[https://github.com/mobify/mobify-platform-sdks/pull/387]
Ticket: WEB-2316
Changes
How To Test
Applicable Research Resources
TODOs: