Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Add optional image cache expiry to the imageResize API #87

Merged
merged 6 commits into from Jan 8, 2013
Merged

Add optional image cache expiry to the imageResize API #87

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f315eb4
* add image cache expiry parameter
b1tr0t Jan 4, 2013
3d38766
* change api call to be more JavaScript-eze
b1tr0t Jan 4, 2013
3151076
Merge remote-tracking branch 'origin/master' into image-cache-expiry
noahadams Jan 7, 2013
ad7d7aa
* allow cache hours to be a string
b1tr0t Jan 7, 2013
eb59c93
Merge branch 'image-cache-expiry' of github.com:mobify/mobifyjs into …
b1tr0t Jan 7, 2013
1f27104
Rely on serverside API to provide error handling. Update tests.
Jan 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/resizeImages.js
View file
Open in desktop
Expand Up @@ -26,6 +26,10 @@ var $ = Mobify.$
bits.push(projectId);
}

if (options.cacheHours && typeof(options.cacheHours) === 'number') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone sets options.cacheHours as a string, then this will silently fail. Probably bad because I would imagine some people might set the value as a string, for example:

options.cacheHours = 27;
options.cacheHours = '27';

I feel like both of those should work. If the argument IS a string, we can check with isNaN or parseInt to determine if it is a valid number, and throw an exception if it is not a number.

bits.push('c' + options.cacheHours)
}

if (options.format) {
bits.push(options.format + (options.quality || ''));
}
Expand Down
16 changes: 16 additions & 0 deletions tests/index.html
View file
Open in desktop
Expand Up @@ -463,6 +463,22 @@ <h2 id="qunit-userAgent"></h2>
}
});

test('Mobify.getImageURL - projectName and cache expiry set', function() {
expect(1);

try {
Mobify.$.fn.resizeImages.defaults.projectName = 'testing';

got = Mobify.getImageURL('http://test/image.jpg',
{maxWidth: 320, cacheHours:8});
vow = "//ir0.mobify.com/project-testing/c8/320/http://test/image.jpg";

equal(got, vow);
} finally {
delete Mobify.$.fn.resizeImages.defaults.projectName;
}
});


module('enhance');

Expand Down