[iOS] maestro record not working since 1.26.0 (#1042)

* fix maestro record not working on iOS due to error=2, No such file or directory exception

* use script file contents inside ProcessBuilder and execute via bash -c

* revert removing comments

maestro-ios-driver/src/main/kotlin/util/LocalSimulatorUtils.kt

@@ -411,23 +411,32 @@ object LocalSimulatorUtils {
 
     fun startScreenRecording(deviceId: String): ScreenRecording {
         val tempDir = createTempDirectory()
-        val script = LocalSimulatorUtils::class.java.getResource("/screenrecord.sh")!!.file
-        val recording = File(tempDir.toFile(), "screenrecording.mov")
+        val inputStream = LocalSimulatorUtils::class.java.getResourceAsStream("/screenrecord.sh")
+        if (inputStream != null) {
+            val recording = File(tempDir.toFile(), "screenrecording.mov")
 
-        val recordingProcess = ProcessBuilder(
-            listOf(
-                script,
-                deviceId,
-                recording.path
+            val processBuilder = ProcessBuilder(
+                listOf(
+                    "bash",
+                    "-c",
+                    inputStream.bufferedReader().readText()
+                )
             )
-        )
-            .redirectInput(PIPE)
-            .start()
+            val environment = processBuilder.environment()
+            environment["DEVICE_ID"] = deviceId
+            environment["RECORDING_PATH"] = recording.path
 
-        return ScreenRecording(
-            recordingProcess,
-            recording
-        )
+            val recordingProcess = processBuilder
+                .redirectInput(PIPE)
+                .start()
+
+            return ScreenRecording(
+                recordingProcess,
+                recording
+            )
+        } else {
+            throw IllegalStateException("screenrecord.sh file not found")
+        }
     }
 
     fun stopScreenRecording(screenRecording: ScreenRecording): File {

maestro-ios/src/main/resources/screenrecord.sh → maestro-ios-driver/src/main/resources/screenrecord.sh

@@ -1,5 +1,3 @@
-#!/usr/bin/env bash
-
 # The `simctl recordVideo` command requires a SIGINT to be sent to stop the recording.
 # Before the SIGINT is sent, the video file is not playable.
 # Kotlin / JVM has no API to sent signals to subprocesses.
@@ -12,13 +10,8 @@
 # Also not that the backend currently does not support hvec. That is why the
 # codec is set to h264.
 
-if [[ $# -ne 2 ]] ; then
-    echo 'Usage: screenrecord.sh <udid> <output file>'
-    exit 1
-fi
-
 echo "Start recording"
-xcrun simctl io "$1" recordVideo --force --codec h264 "$2" &
+xcrun simctl io "$DEVICE_ID" recordVideo --force --codec h264 "$RECORDING_PATH" &
 simctlpid=$!
 
 echo "Simctl pid $simctlpid"