Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Be able to define actual folder name of debug output rather than using datetime so we can access screenshots on CI runs #1427

Closed
simon-gilmurray opened this issue Sep 7, 2023 · 6 comments · Fixed by #1748
Closed

[Feature Request] Be able to define actual folder name of debug output rather than using datetime so we can access screenshots on CI runs #1427

simon-gilmurray opened this issue Sep 7, 2023 · 6 comments · Fixed by #1748
Labels
enhancement New feature request or improvement of an existing feature

Comments

@simon-gilmurray
Copy link

Is your feature request related to a problem? Please describe.
Unable to access screenshots/logs on CI due to the folder name being created using datetime at runtime

Describe the solution you'd like
Be able to define the actual folder the debug output screenshots/logs gets saved in, currently you can define the root folders but it always adds a folder at the end with the datetime of the run. This means it’s very difficult to be able to access these within CI if ever there’s a failure, as we have no idea what the folder will be called prior to the run.
@simon-gilmurray simon-gilmurray added the enhancement New feature request or improvement of an existing feature label Sep 7, 2023
@Fishbowler
Copy link
Contributor

Would you expect this to be another flag to specify a subfolder?
Or a flag that says "just put it where I said, no subfolders"?

@simon-gilmurray
Copy link
Author

Would you expect this to be another flag to specify a subfolder? Or a flag that says "just put it where I said, no subfolders"?

Either works 🙂

@Fishbowler
Copy link
Contributor

If there's a --flatten-debug-output flag, is it worth removing the .maestro/tests/ bit from the path too?

@Fishbowler
Copy link
Contributor

Had a play, and came up with this: Fishbowler@972f615

Does this look like it would do what you want?

@simon-gilmurray
Copy link
Author

Nice one, looks great!

This was referenced Sep 13, 2023
Closed
Open
@Fishbowler Fishbowler mentioned this issue May 17, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar problem, please file a new issue. Make sure to follow the template and provide all the information necessary to reproduce the issue.
Thank you for helping keep us our issue tracker clean!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature request or improvement of an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@Fishbowler @simon-gilmurray